fix: Replace space with tabulator and enter as separators#12730
Merged
villebro merged 1 commit intoapache:masterfrom Jan 25, 2021
Merged
fix: Replace space with tabulator and enter as separators#12730villebro merged 1 commit intoapache:masterfrom
villebro merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12730 +/- ##
==========================================
- Coverage 66.83% 66.41% -0.42%
==========================================
Files 1022 1022
Lines 49992 49992
Branches 4892 5023 +131
==========================================
- Hits 33410 33201 -209
- Misses 16457 16666 +209
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
reviewed
Jan 25, 2021
villebro
approved these changes
Jan 25, 2021
villebro
pushed a commit
that referenced
this pull request
Jan 26, 2021
This was referenced Mar 11, 2024
mistercrunch
added
🍒 1.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Disable confirming value with space button and replace it with tabulator and enter buttons - now we can use multi-word values like "Russian Federation".
Closes #12644
Fixes #12644
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Nagranie.z.ekranu.2021-01-25.o.09.51.49.mov
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc @zuzana-vej @villebro